Skip to content

Comments

nixos/firefox: detail the format of preferences#260204

Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom
06kellyjac:firefox_preferences
Mar 23, 2025
Merged

nixos/firefox: detail the format of preferences#260204
FliegendeWurst merged 1 commit intoNixOS:masterfrom
06kellyjac:firefox_preferences

Conversation

@06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Oct 10, 2023 •
edited
Loading

Description of changes

Detail the format of preferences in the docs

image

cc: @danth

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 10, 2023
@06kellyjac 06kellyjac added the 8.has: documentation This PR adds or changes documentation label Oct 10, 2023
@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Oct 10, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 10, 2023
@jian-lin jian-lin requested a review from linsui October 10, 2023 16:32
jian-lin
jian-lin reviewed Oct 10, 2023
View reviewed changes
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 10, 2023
danth
danth reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me what is meant by a "full string". Could you elaborate?

@06kellyjac
Copy link
Member Author

06kellyjac commented Oct 10, 2023

{ "x.y.z" = blah; } instead of { x.y.z = blah; }

Im open to different wording

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 5, 2025
@FliegendeWurst FliegendeWurst added the 8.has: documentation This PR adds or changes documentation label Mar 23, 2025
@FliegendeWurst FliegendeWurst merged commit b1efffe into NixOS:master Mar 23, 2025
24 of 28 checks passed
@06kellyjac 06kellyjac deleted the firefox_preferences branch October 17, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jian-lin jian-lin jian-lin left review comments

+2 more reviewers

@danth danth danth left review comments

@linsui linsui linsui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@06kellyjac @danth @linsui @jian-lin @delroth @wegank @FliegendeWurst @SigmaSquadron